Overview

Request 675195 accepted

- version 0.85.2
- Fixed changes file to mention relevant github pull requests.
- Removed remaining preun rpm hook from EOL openSUSE versions
- Merged /var/adm/netconfig move revert from openSUSE:Factory
causing to not find md5 sums from previous netconfig version
due to incorrectly merged hook in spec file and trouble on
transactional systems without writeable /var/lib/netconfig.
Removed obsoletes revert-var-adm-lib-netconfig-move.patch.
(bsc#1124152,bsc#1124340).
- Merged rpm spec bash section marks (gh#openSUSE/sysconfig#23)

- Remove code to update from openSUSE older than 12.3, which is EOL
(gh#openSUSE/sysconfig#19).
- Move /var/adm/netconfig to /var/lib/netconfig to become more FHS
conform (gh#openSUSE/sysconfig#18).

Loading...

Richard Brown's avatar

I'm pretty sure this wont work on a transactional system (such as Kubic, CaaSP, or the Transactional Server role on SLE 15 SP1, Leap, or Tumbleweed)


Jan Engelhardt's avatar

Hm, you're removing the %pre scriptlet entirely, but add new Requires(pre)? Somehow I'm missing something.


Ignaz Forster's avatar

I agree with Richard: The netconfig post script will not have the intended effect on transactional systems. The reason is that /var is not mounted into the update environment (because that would actually change the state of the currently running system).

The common way to solve this is to write a systemd unit handling the migration.



Stephan Kulow's avatar

common agreement is that the move from /var/adm to /var/lib does more harm than good, so I will hotpatch the revert in Factory. In the hope that Marius and Thorsten's team will sort out a solution next week


Marius Tomaschewski's avatar
author reviewer source maintainer

IMO we don't need another solution -- the /var/adm (and /var/lib) directory are not used any more, except to migrate from from file + md5 to a link.

I'm going to merge the openSUSE:Factory changes reverting the move to git and resubmit it.

Request History
Marius Tomaschewski's avatar

mtomaschewski created request

- version 0.85.2
- Fixed changes file to mention relevant github pull requests.
- Removed remaining preun rpm hook from EOL openSUSE versions
- Merged /var/adm/netconfig move revert from openSUSE:Factory
causing to not find md5 sums from previous netconfig version
due to incorrectly merged hook in spec file and trouble on
transactional systems without writeable /var/lib/netconfig.
Removed obsoletes revert-var-adm-lib-netconfig-move.patch.
(bsc#1124152,bsc#1124340).
- Merged rpm spec bash section marks (gh#openSUSE/sysconfig#23)

- Remove code to update from openSUSE older than 12.3, which is EOL
(gh#openSUSE/sysconfig#19).
- Move /var/adm/netconfig to /var/lib/netconfig to become more FHS
conform (gh#openSUSE/sysconfig#18).


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Antonio Larrosa's avatar

alarrosa accepted review


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:F


Yuchen Lin's avatar

maxlin_factory changed priority to moderate => important

raising priority for openSUSE:Factory:Staging:F


Repo Checker's avatar

repo-checker accepted review

Accepted as part of openSUSE:Factory:Staging:F


Stephan Kulow's avatar

coolo accepted review

ready to accept


Stephan Kulow's avatar

coolo approved review

ready to accept


Stephan Kulow's avatar

coolo accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by