Request 678944 (accepted)

You're not reviewing the full diff of request 678944 , but the diff to the superseded request 669145 (Show full diff)

Overview

Request 678944 accepted

Update to 11.2

Created by rmax about 5 years ago
In state accepted
Supersedes 669145

Submit postgresql11

Comments for request 678944 10

Stephan Kulow (coolo) - about 5 years ago

file conflict with pg10-devel

Reinhard Max (rmax) - about 5 years ago

author source maintainer

Yes, the devel packages are always exclusive between different PG versions, that's not new between 10 and 11.

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

From the man pages:

pg_config [option...]
Description

The pg_config utility prints configuration parameters of the currently installed version of PostgreSQL. It is intended, for example, to be used by software packages that want to interface to PostgreSQL to facilitate finding the required header files and libraries.

Not having pg_config in the -devel package (or its dependencies) just adds increased burden on our packagers where there is no practical need for it

From the rings, I see at least those build failures:

Build failed apr-util (i586, x86_64)
Build failed libreoffice (i586, x86_64)
Build failed postfix (i586, x86_64)
Build failed redland (i586, x86_64)

Reinhard Max (rmax) - about 5 years ago

author source maintainer

I consider this a bug in upstream documentation. It looks like they forgot to change it after support for pkg-config was added and the collection of used libraries was cleaned up between the backend and the frontend. If you look at the build-time dependencies that pg_config adds you'll see that it is clearly meant for backend extensions, because it pulls in a lot of libs that libpq doesn't depend on.

BTW, the split of the devel package and move of pg_config to the server side was triggered by a change in the upstream build system that went into version 11. This makes it harder if not impossible to build the libs and pg_config without also building the backend. But we build the libs separately to foster parallelism in the build service, because otherwise PostgreSQL would be a bottleneck for bootstrapping the distribution (ask Rudi). Making -devel dependend on -server-devel to get pg_config back would also bring the bottleneck back, because packages that link to the client libs would again have to wait until the main package has been built.

I already submitted fixes for three of the five packages that currenly fail in staging:I and will do the rest on Monday. Most of them already use pkg-config for other libs they depend on, so fixing them is not hard and getting our patches upstream should not be an issue.

There might be another set of packages that don't fail, but silently lose PostgreSQL support when they can't find pg_config at build time. We need to look into that as well.

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

Thanks for the explanation @rmax - Indeed, the upstream doc seems like it was forgotten then.

I'll be looking forward to the fixes for the five staging-blockers, once we get them ready, we should be able to move forward with pgsql11

Bruno Friedmann (bruno_friedmann) - about 5 years ago

source maintainer

about pg_config at build time, we need to have a look at gdal, when I tried last week to build one against s:d:postgres I was not able to have support for postgresql. I'm now waiting the package fixes.

Dominique Leuenberger (dimstar_suse) - about 5 years ago

reviewer target maintainer

Waiting for apr-util, libreoffice, redland and rsyslog fixes

Reinhard Max (rmax) - about 5 years ago

author source maintainer

I have submitted them all to the respective devel projects, and at least the fix for libreoffice has already been accepted in Factory.

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

found conflict of postgresql11-server-devel-11.2-5.1.x86_64 with postgresql93-devel-9.3.24-3.11.x86_64:
  - /usr/lib64/libpgcommon.a
  - /usr/lib64/libpgport.a
  - /usr/include/pgsql/server/c.h
  - /usr/include/pgsql/server/dynloader.h
  - /usr/include/pgsql/server/fmgr.h

Reinhard Max (rmax) - about 5 years ago

author source maintainer

https://build.opensuse.org/request/show/683926

Request History

rmax created request about 5 years ago

Update to 11.2

dimstar_suse added as a reviewer about 5 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:adi:52"

dimstar_suse accepted review about 5 years ago

Picked openSUSE:Factory:Staging:adi:52

factory-auto added opensuse-review-team as a reviewer about 5 years ago

Please review sources

factory-auto added repo-checker as a reviewer about 5 years ago

Please review build success

factory-auto accepted review about 5 years ago

Check script succeeded

coolo set openSUSE:Factory:Staging:I as a staging project about 5 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:I"

coolo accepted review about 5 years ago

Moved to openSUSE:Factory:Staging:I

dimstar accepted review about 5 years ago

coolo accepted review about 5 years ago

Removing from openSUSE:Factory:Staging:I, re-evaluation needed

coolo added factory-staging as a reviewer about 5 years ago

Requesting new staging review

coolo declined request about 5 years ago

what's new though: postgresql11-server-devel doesn't conflict with postresql10-devel but has file conflicts still

rmax reopened request about 5 years ago

Ah, a provides for postgresql-server-devel-exclusive was missing from postgresql10.spec . I've added it now, but cannot submit to Factory from server:database:postgresql, because you made home:coolo:postgresql10 the devel project for postgresql10.