This request supersedes:
request 681202
(Show diff)
Overview
Request 681214 accepted
- Remove bcond preventing tests from running, use IMAGEIO_NO_INTERNET
to activate tests which can run without the internet, and skip
currently failing tests on Python 2 and 3
- Remove unused test dependency nose
- Recommend Pillow as it is a mandatory dependency of the test suite
Loading...
Request History
jayvdb created request
- Remove bcond preventing tests from running, use IMAGEIO_NO_INTERNET
to activate tests which can run without the internet, and skip
currently failing tests on Python 2 and 3
- Remove unused test dependency nose
- Recommend Pillow as it is a mandatory dependency of the test suite
scarabeus_iv accepted request
Upstream released version 2.5 26 days ago; does that one fix the test failures?
No, and upgrading imageio is a huge undertaking, especially if we are going to de-vendor it. Starting at https://build.opensuse.org/project/show/home:jayvdb:python-imageio
https://build.opensuse.org/package/show/home:jayvdb:python-imageio/python-imageio-ffmpeg is the first part and the .spec there gives some idea of the dragons that be here
Well that will be certainly fun. Just to keep you even more happy it is not legal to put in that ffmpeg supporting mp4 you take from the wheel in there at all.
ya, I am aware of that. I used to work for a more legal-anal Unix that openSUSE :P I intend to remove it before submitting it, which is why I have created a separate bcond for it, so people can test it if they want to, as it is the canonical way of using the library.
that = than
to more directly reply, most of the functionality of imageio is all in either vendored or downloaded libraries/executables, and opensuse doesnt have the vendored libraries, and the built executables are incompatible because of lack of codecs added in the builds (e.g. ffmpeg, due to valid licensing concerns)
And also, in order to update imageio, moviepy also needs updating at the same time, otherwise it becomes broken.
Can I get a real review please. I want to start de-vendoring this, and would like the tests in first so I can use them as a baseline for the de-vendoring.
@TheBlackCat, @alarrosa, @aplanas, @cyberiad, @czerw, @dirkmueller, @glaubitz, @mcepl, @mimi_vx, @pavlix, @posophe, @rjschwei, @scarabeus_iv, @sleep_walker, @tbechtold: review reminder