Overview
Request 714721 superseded
Supersedes 714691 - fixes license issue, summary is changed, desktop file isn't hardcoded, other things are tidied up
- Created by Appadeia
- In state superseded
-
Package maintainer:
Appadeia
- Supersedes 714691
- Superseded by 715518
License: GPL-2.0
Minor nitpick: Please use either GPL-2.0-only or GPL-2.0-or-later. (btw, if you plan to upstream it to KDE at some point: They won't accept new GPL code without "or any later version" clause.)
"KDE Icon Preview" in the summary doesn't reflect the KDE branding: KDE is not the DE, but the community.
Please run spec-cleaner to clean the formatting. I suggest changing the hardcoded path in ikona.desktop to only leave the executable name.
The LICENSE file indicates the license tag shall be GPL-2.0-or-later
Also rename the spec and changes files to match the package name as suggested by the rpmlint warning: [ 107s] ikona.src: W: invalid-spec-name
The spec matches the package name I'm submitting to: KDE:Extra/ikona, not KDE:Extra/kicon-preview.
no: kicon-preview.changes kicon-preview.spec submitting the package with a different name won't rename the spec and changes file
Request History
Appadeia created request
Supersedes 714691 - fixes license issue, summary is changed, desktop file isn't hardcoded, other things are tidied up
Vogtinator declined request
Please run spec-cleaner and add missing runtime requirements (kirigami2, plasma-framework-components?)
Supersedes 714721 - nicer formatting, better metadata, add deps
What's the purpose of this?
It should go, hidden directories need to be avoided.
That's used by KIO's "Create New" context menu templates.
Indeed, and it mandates using a hidden directory (for whatever reason). That's ugly, but in this case necessary.
you didn't run 'spec-cleaner' yet.
I wonder whether KDE:Extra is the right place, do you intend to submit this to kdereview?
Most likely not in the near future. Where do you think I should submit this instead?
%{_datadir}/templates/ is too generic, please move these files into /usr/share/ikona or something else more specific.
%{_datadir}/templates/ is already used for other (KDE) templates (kio's "Create New..." context menu e.g. as mentioned above). I'm not sure whether it makes sense here though.
As it BuildRequires cmake(KF5Kirigami2), it probably needs kirigami2 at runtime too. In that case, it should Require it.
@Vogtinator, @alarrosa, @cgiboudeaux, @christiantrippe, @dirkmueller, @luca_b, @tittiatcoke, @wolfi323: review reminder