Overview
Request 81727 accepted
- Spec file cleanup as suggested by the spec-cleaner tool.
+ Make all BuildRequires, PreReq, and Provides a separate line.
+ Use %{buildroot} instead of ${RPM_BUILD_ROOT}.
+ Use straight commands instead of macros (make, install).
+ Use -p in post and postun if we only call one command.
+ Use %{_localstatedir} instead of %{_var} in the filelist.
+ Remove superfluous AutoReqProv on lines.
- Remove %release from all Provides.
- Fix segfault in iconv.c which caused a null pointer dereference; (bso#8433).
- Use /var/run for the cifs state file in the init script too; (bnc#710304).
- Fix CUPS print job IDs; (bso#7288); (bnc#701257).
Request History
lmuelle created request
- Spec file cleanup as suggested by the spec-cleaner tool.
+ Make all BuildRequires, PreReq, and Provides a separate line.
+ Use %{buildroot} instead of ${RPM_BUILD_ROOT}.
+ Use straight commands instead of macros (make, install).
+ Use -p in post and postun if we only call one command.
+ Use %{_localstatedir} instead of %{_var} in the filelist.
+ Remove superfluous AutoReqProv on lines.
- Remove %release from all Provides.
- Fix segfault in iconv.c which caused a null pointer dereference; (bso#8433).
- Use /var/run for the cifs state file in the init script too; (bnc#710304).
- Fix CUPS print job IDs; (bso#7288); (bnc#701257).
coolo added a reviewer
Please review sources
saschpe approved review
ok, 'Release' tag occurs twice but that's no big deal ;-)
lrupp accepted request
Accepted submit request 81727 from user saschpe
licensedigger accepted review
{"approve": "license and version number unchanged: 3.6.0"}
coolo accepted review
Builds for repo openSUSE_Factory
Output of check script (non-fatal):
- package has baselibs.conf: (unchanged)
WARNING: macro used in version line
packager is responsible that the resulting string
is non-empty and contains no "-".
----------
%package -n libtalloc2
Version: %{libtalloc_ver}
Release: 4
License: LGPLv3+
--
%package -n libtalloc-devel
Version: %{libtalloc_ver}
Release: 4
License: LGPLv3+
--
%package -n libtdb1
Version: %{libtdb_ver}
Release: 4
License: LGPLv3+
--
%package -n libtdb-devel
Version: %{libtdb_ver}
Release: 4
License: LGPLv3+
--
%package -n libtevent0
Version: %{libtevent_ver}
Release: 4
License: LGPLv3+
--
%package -n libtevent-devel
Version: %{libtevent_ver}
Release: 4
License: LGPLv3+
--
%package -n libldb1
Version: %{libldb_ver}
Release: 4
License: LGPLv3+
--
%package -n libldb-devel
Version: %{libldb_ver}
Release: 4
License: LGPLv3+
----------
samba/samba.spec has a %pre with groupadd and/or useradd (unchanged)
saschpe accepted review
ok, 'Release' tag occurs twice but that's no big deal ;-)
