Overview
Request 908577 superseded
I think the tools should be in dist repo.
- Created by Yav
- In state superseded
- Supersedes 908079
- Superseded by 908580
- Open review for hardware / android-tools
-
Open review for
licensedigger
- Open review for openSUSE:Factory:Staging:adi:38
@Yav Please rename this package to "android-platform-tools"
@namtrac Why?
Tools are from android-platform-system-core git repository, also link https://developer.android.com/studio/releases/platform-tools suggest platform in the name, thus it'd make sense to call it android-platform-tools. But if package was already named android-tools, it might be better to keep it although it's quite ambiguous (android is quite wide topic, platform is more specific).
It was named "android-tools" before it got dropped from Factory in 2017
Well, yes. And it was wrong then too. Now there's a chance to fix it.
of course, I was just hinting on how the package name might have been conceived ;-)
Maybe researching on how other distributions name the package (if they have one...) would be useful, to avoid the usual "on debian, install foobar-lib, on redhat, install libfoobar and on suse, install libfoobar4" documentation nightmare.
Actually having android-tools was a correct decision :)
android-tools * alpine (https://pkgs.alpinelinux.org/package/edge/community/x86_64/android-tools) * fedora (https://src.fedoraproject.org/rpms/android-tools) * gentoo (https://packages.gentoo.org/packages/dev-util/android-tools)
Only different are Debian and Arch Linux Arch Linux https://aur.archlinux.org/packages/android-sdk-platform-tools/
Debian renamed package from android-tools-{adb,fastboot} into just {adb,fastboot} (https://packages.debian.org/search?keywords=adb, https://packages.debian.org/search?keywords=fastboot). But they have full installation of https://android.googlesource.com/platform/system/core (https://tracker.debian.org/pkg/android-platform-system-core)
the 'platform' in android-platform-tools does not add any information, only makes the name longer.
It's the upstream name.
We use https://github.com/nmeum/android-tools and "android-tools" is its name but whatever. I'll rename the package even though it's wrong.
Request History
Yav created request
I think the tools should be in dist repo.
RBrownSUSE added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:38"
RBrownSUSE accepted review
Picked "openSUSE:Factory:Staging:adi:38"
factory-auto declined review
A package submitted as android-tools has to build as 'Name: android-tools' - found Name 'android-platform-tools'
factory-auto declined request
A package submitted as android-tools has to build as 'Name: android-tools' - found Name 'android-platform-tools'
