Overview
Request 927971 accepted
Fix for problems with building MozillaFirefox; see boo#1192067
- Created by manfred-h
- In state accepted
-
Open review for
federico-mena
-
Open review for
luke_nukem
-
Open review for
firstyear
Loading...
openSUSE Build Service is sponsored by
Somehow I do not see that this is the correct change? Seems to me that for any rust version we should use the system llvm iff match the bundled version, and if not uses the bundled one. If we do not do that, this Rust version will still be broken in SLE.
But good catch!!
For TW the change is correct. The improved version (if possible at all) is to make this more generic in spec file syntax but not sure how to implement the logic you are describing. I think the SLE versions already build using bundled llvm regardless but probably not all.
Usually Rust goes to some lengths to support multiple LLVM versions, not just the one they use for their own builds. And Tumbleweed will typically not just have the latest versions, but some previous versions as well. So even if it doesn't match the system default, I think it's still preferable to use an existing
llvmXX-develpackage instead of the bundled version. (LLVM is pretty big, so we better not build/ship it twice.)On Leap 15.3 we don't have
llvm12but onlyllvm11(plus some older versions).@firstyear: review reminder
The changes to 15.3 will not appear immediately in leap as I need to cross submit them to SLE. But I'll do that after this. I agree that we should pin to llvm versions from now on.