Fast, simple and secure messaging app from your desktop
https://github.com/signalapp/Signal-Desktop/
Signal Desktop is an Electron application that links with your Signal Android
or Signal iOS app.
-
7
derived packages
- Download package
-
Checkout Package
osc -A https://api.opensuse.org checkout network:im:signal/signal-desktop && cd $_
- Create Badge
Refresh
Refresh
Comments 18
Do you know how often electron makes ABI-breaking changes? If minor updates are OK, it might be worth doing something like this:
Requires: nodejs-electron%{?_isa} >= %{electron_req_version}
Requires: nodejs-electron%{?_isa} < 17 (or whatever is current version + 1)
My Bitwarden binaries built with Electron 13 ( https://build.opensuse.org/package/show/home:dziobian:gulgul-ultron/bitwarden ) work fine on 16, but Signal does not, so there seem to be at least two types of binary Node modules.
Signal requires header files for electron which are being downloaded. Same for nodejs, so the header files in the vendor tarball need to match exactly the nodejs and electron version to be able to build it.
Yes, it is quite a mess.
The nodejs headers are provided in nodejs16-devel and can be used adding --nodedir=/usr/include/node16 to npm command line. Unfortunately the SuSE distribution of electron does not include devel headers. Ouch.
My question was different tho. I was asking whether binaries built against electron 16.0.1 can run with electron 16.0.2.
Yes, that should work. I was even able to run signal-desktop built against electron 13 with electron 15. However signal-desktop build with 15 and running with 16 doesn't work. Minor version updates should work.
I will look into node includes soon. However it still downloads electron headers from the web. Maybe we can package them too.
If I do
export npm_config_nodedir=/usr/include/node16
node-gyp doesn't find the header:
https://bugzilla.opensuse.org/show_bug.cgi?id=1195164
The environment variable seems to not work, you need to use
--prefix=…
. See how i did it in my spec for bitwardenThat's just a workaround. I think right fix is that the common.gypi sets the include path correctly.
I also see the remove-heif support patch, that's uncool, I'll miss out on lots of dog and food pictures!
Seriously, anything that can be done to have working heif support? As disabling that means 99% of the pics I get don't show :D Or does it work and does this patch do something else... Sorry, just curious I guess.
Tell your friends to use royalty free image formats.
Thank you for your dedication and hard work! This is so much appreciated!!!
I agree. Thank you for all you do. Just out of curiosity, is anyone else having issues with spellcheck working?
Hello everybody, why is signal not submitted to Factory? Just a curious question
https://build.opensuse.org/package/show/home:ithod:signal/signal-desktop#comment-1649266
@dziobian Have you reconsidered this after submitting bitwarden?
I heavily prune bitwarden's node_modules, and don't run the test suite there. Also they're not as code-bloat-happy as signal.
Also bitwarden now is at risk of getting stuck with an outdated version due to the wasm module. (The licensing situation got resolved with upstream, but i did not have enough free time to get it to build yet)
Hi. It looks like one or more of the packages have been signed using an expired GPG key. This causes installation on Fedora to fail. At the moment the (horrible) workaround is to ignore GPG checks:
sudo dnf --nogpgcheck install signal-desktop
I have filed a bug here:
https://bugzilla.opensuse.org/show_bug.cgi?id=1245441
As this is done automatic by the build service, could you check/compare to https://build.opensuse.org/projects/network:im:signal/signing_keys
Hi. I'm not confident with certificate management/querying, but after some Googling and help from someone in the Fedora discussion groups:
Is this what you were after? If not, please let me know what commands to run.
Also, should I update the ticket with the above?
Again - many thanks.