Overview
Request 1077746 revoked
***NOTE ONLY FOR PYTHON 3.10 and GREATER***
I suspect some repositories will need to be disabled!
- Updated to version 1.2.0+65:
- Only supports python 3.10 or greater.
- Code cleanup for python 3.10 collection changes.
- Spec file cleanup to remove obsolete calls and use python3.
- Add service to pull latest git version.
- Drop man page.
- Add license files for assets (eg icons) and code.
- Drop makehuman-startscript.patch as softlink now created instead.
- Add makehuman.rpmlintrc to ignore rpmlint zero-file-length error.
- Created by malcolmlewis
- In state revoked
- Supersedes 1077199
Still has BuildRequires: python (2!)
Package contains python2 bytecode
Several dead commands in the spec file (rm -Rf ..., find ... -delete)
Request History
malcolmlewis created request
***NOTE ONLY FOR PYTHON 3.10 and GREATER***
I suspect some repositories will need to be disabled!
- Updated to version 1.2.0+65:
- Only supports python 3.10 or greater.
- Code cleanup for python 3.10 collection changes.
- Spec file cleanup to remove obsolete calls and use python3.
- Add service to pull latest git version.
- Drop man page.
- Add license files for assets (eg icons) and code.
- Drop makehuman-startscript.patch as softlink now created instead.
- Add makehuman.rpmlintrc to ignore rpmlint zero-file-length error.
StefanBruens declined request
See comment
malcolmlewis revoked request
The source project 'home:malcolmlewis:branches:graphics' has been removed
This comment has been deleted
"BuildRequires: mercurial" looks strange for a project using git(hub)
What use case is there for the single-use "%pythons" macro?
"BuildRequires: python3" (after expanding %pythons) should be "BuildRequires: python3-base".
LICENSE.ASSETS.md likely belongs into the data subpackage.
Still several unused (i.e. MacOS/Windows) icons packaged (already noted in an earlier review). Only PNG and likely SVG should be kept.
You should use the "%python3_compile" macro from the python-rpm-macros package, you invocation leaves the buildroot path in the cache files.
@StefanBruens, @WernerFink, @adrianSuSE, @bruclik, @dstoecker, @jsmeix, @jubalh, @kfreitag, @mseben, @msmeissn, @t-paul, @toganm: review reminder