Overview
Request 224728 superseded
- Only send "Proxy-Authenticate" replies when we are in a forward proxy.
- Clean up compile warnings on 64-bit architectures; (bnc#866921).
- Ensure that the authenticated user context is set to NULL when freed.
- Add a workaround for proxy authorization in IE.
- Fix a typo in strcmp usage in process_msg().
- Created by lmuelle
- In state superseded
- Superseded by 226458
Request History
lmuelle created request
- Only send "Proxy-Authenticate" replies when we are in a forward proxy.
- Clean up compile warnings on 64-bit architectures; (bnc#866921).
- Ensure that the authenticated user context is set to NULL when freed.
- Add a workaround for proxy authorization in IE.
- Fix a typo in strcmp usage in process_msg().
factory-auto added a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
factory-auto added a reviewer
Please review build success
factory-auto added a reviewer
Pick Staging Project
licensedigger accepted review
{"approve": "license and version number unchanged: 0.0.0.lorikeet_svn_682"}
factory-repo-checker accepted review
Builds for repo Apache_openSUSE_Factory
dimstar declined request
Please see
http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Patch_live_cycle
=> Added / removed patches need to be mentioned by name in .changes, in
order to get a full trail of life cycles.
lmuelle added a reviewer
The bugs are referenced in the particular patch header.
I'll not start to duplicate this information into the package change log. If other projects like to do this I'm fine. But we'll not do it for Samba not will I blow up the package change log file - which is an interface to our end users - by this.
coolo accepted review
dimstar declined request
The decline reason was not about patch tagging / markup.. but about the fact that the addition / removal of the same shall be documented in .changes.
lmuelle added a reviewer
Four patches and four lines in the change log _and_ the change log content correspondent to the comment in the header of the patch.
Merge this change set and don't make easy things harder than required, please.
sleep_walker declined request
Lars,
please, add into changelog:
- patches added:
8066631e2c6783ecb49728e56ee69f28c5e23850.patch
e7c5973f8b605c1b1a72a9274820a4139dfc12a9.patch
9ee438092c411d77f9f4e8b3eafe72ec9161fb0c.patch
349884de1e294f40285060ad9c75895b574d373d.patch
34466e43ebba0d8a877bb14b3688ddea1272ed7a.patch
Your naming scheme for patches is ugly. It doesn't say anything about the purpose, version it applies. Information about the commit is already inside.
and make us happy. We really try hard to standardize the process and even
though the information is redundant (you could find it somewhere in osc
history), it's much easier to reach it this way.
We don't want make easy things harder - please do not follow your opinion in
this case, but follow the rules.
sleep_walker declined review
Lars,
please, add into changelog:
- patches added:
8066631e2c6783ecb49728e56ee69f28c5e23850.patch
e7c5973f8b605c1b1a72a9274820a4139dfc12a9.patch
9ee438092c411d77f9f4e8b3eafe72ec9161fb0c.patch
349884de1e294f40285060ad9c75895b574d373d.patch
34466e43ebba0d8a877bb14b3688ddea1272ed7a.patch
Your naming scheme for patches is ugly. It doesn't say anything about the purpose, version it applies. Information about the commit is already inside.
and make us happy. We really try hard to standardize the process and even
though the information is redundant (you could find it somewhere in osc
history), it's much easier to reach it this way.
We don't want make easy things harder - please do not follow your opinion in
this case, but follow the rules.
superseded by 226458
