this breaks vinagre

 plugins/rdp/vinagre-rdp-tab.c: In function 'frdp_post_connect':
[  103s] plugins/rdp/vinagre-rdp-tab.c:596:21: error: 'CLRBUF_32BPP' undeclared (first use in this function)
[  103s]                      CLRBUF_32BPP,
[  103s]                      ^~~~~~~~~~~~
[  103s] plugins/rdp/vinagre-rdp-tab.c:596:21: note: each undeclared identifier is reported only once for each function it appears in
[  103s] plugins/rdp/vinagre-rdp-tab.c:590:3: error: too many arguments to function 'gdi_init'
[  103s]    gdi_init (instance,
[  103s]    ^~~~~~~~
[  103s] In file included from plugins/rdp/vinagre-rdp-tab.c:31:0:
[  103s] /usr/include/freerdp2/freerdp/gdi/gdi.h:539:18: note: declared here
[  103s]  FREERDP_API BOOL gdi_init(freerdp* instance, UINT32 format);

Dominique Leuenberger (dimstar) - over 7 years ago

reviewer

Yes, I'm on it together with vinagre upstream

Vinagre is still not ready for those API changes

Seems there's a patch for vinagre https://bugzilla.gnome.org/show_bug.cgi?id=775616 Has it been tried ?

I admit for myself I prefer to have a working freerdp (which I always used from command line) with a fixed copy and paste between windows hosts than the version we have actually in factory. I'm a bit worried to the fact that last core work in vinagre is now more than one year, it look like there's not that much people contributing to it.

@dimstar_suse, @factory-repo-checker: review reminder

Unignored: returned to active backlog.