Overview
Request 676356 superseded
- Modified the spec file to add a group named cpacfstats
(bsc#1123730)
- Created by markkp
- In state superseded
- Supersedes 676268
- Superseded by 678097
-
Open review for
jengelh
-
Open review for
factory-staging
+getent group cpacfstats >/dev/null 2>&1 2>&1 || groupadd -r cpacfstats
I'm sure that "2>&1" needlessly duplicated.
Request History
markkp created request
- Modified the spec file to add a group named cpacfstats
(bsc#1123730)
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
namtrac accepted review
jengelh accepted review
staging-bot added openSUSE:Factory:Staging:D as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:D"
staging-bot accepted review
Picked openSUSE:Factory:Staging:D
jengelh added jengelh as a reviewer
repo-checker accepted review
cycle and install check passed
maxlin_factory changed priority to moderate => important
raising priority for openSUSE:Factory:Staging:D
maxlin_factory accepted review
Removing from openSUSE:Factory:Staging:D, re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
If there is an error in getent (or any other portion), the administrator should be made aware of it, it should not be hidden IMO.
A fix is in 676375, that SR also fixes other present issues, such as sh compat (alternative: /bin/bash markup), which seems reasonably favored by others on the ML.
So 676356 should not pass until those low hanging fruit are addressed.
If getent fails for any reason, the groupadd command will be executed. Any error from that will be displayed. The package has been this way for aeons, and nobody has complained. I see no reason to hold this request. Please proceed.
"we always did it this way" is not a very good argument. There are 400 getent calls in Factory, only 22 of which have
2>, and that is mostly remnants that have not been noticed yet, that is to say, I point out the 94% conformance of the rest.Oh well. Find a real problem and I'll consider fixing it.
Well thank you for pointing out there is some more to fix.