Request 678097 (accepted)

You're not reviewing the full diff of request 678097 , but the diff to the superseded request 676356 (Show full diff)

Overview

Request 678097 accepted

- Now that IBM has the package on github, use a full source URL.
- Change Pre-Req to Requires(pre) and (post), and remove dracut.
- Changed the group for the hmcdrvfs package from Base:System to
Base/Filesystems
- Institute the %autosetup macro.
- Remove erroneous %dir entry for %_unitdir
- Change bash-specific "==" tests in scriptlets with a more
generic "=".
- Modified the spec file to add a group named cpacfstats
(bsc#1123730)

Created by markkp about 5 years ago
In state accepted
Supersedes 676356

Submit s390-tools

Comments for request 678097 0
Comments for request 676356 5

Jan Engelhardt (jengelh) - over 5 years ago

reviewer

If there is an error in getent (or any other portion), the administrator should be made aware of it, it should not be hidden IMO.

A fix is in 676375, that SR also fixes other present issues, such as sh compat (alternative: /bin/bash markup), which seems reasonably favored by others on the ML.

So 676356 should not pass until those low hanging fruit are addressed.

Mark Post (markkp) - over 5 years ago

author

If getent fails for any reason, the groupadd command will be executed. Any error from that will be displayed. The package has been this way for aeons, and nobody has complained. I see no reason to hold this request. Please proceed.

Jan Engelhardt (jengelh) - over 5 years ago

reviewer

"we always did it this way" is not a very good argument. There are 400 getent calls in Factory, only 22 of which have 2>, and that is mostly remnants that have not been noticed yet, that is to say, I point out the 94% conformance of the rest.

Mark Post (markkp) - over 5 years ago

author

Oh well. Find a real problem and I'll consider fixing it.

Jan Engelhardt (jengelh) - over 5 years ago

reviewer

Well thank you for pointing out there is some more to fix.