Overview
Request 678945 accepted
- Drop use of $FIRST_ARG in .spec
The use of $FIRST_ARG was probably required because of the
%service_* rpm macros were playing tricks with the shell positional
parameters. This is bad practice and error prones so let's assume
that no macros should do that anymore and hence it's safe to assume
that positional parameters remains unchanged after any rpm macro
call.
- Change the persmissions for /var/run/postgresql to 1775, so that
the directory can only be used by users in the postgres group
(bsc#1123886).
Request History
rmax created request
- Drop use of $FIRST_ARG in .spec
The use of $FIRST_ARG was probably required because of the
%service_* rpm macros were playing tricks with the shell positional
parameters. This is bad practice and error prones so let's assume
that no macros should do that anymore and hence it's safe to assume
that positional parameters remains unchanged after any rpm macro
call.
- Change the persmissions for /var/run/postgresql to 1775, so that
the directory can only be used by users in the postgres group
(bsc#1123886).
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
coolo set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
coolo accepted review
Picked openSUSE:Factory:Staging:I
dimstar accepted review
coolo accepted review
Removing from openSUSE:Factory:Staging:I, re-evaluation needed
coolo added factory-staging as a reviewer
Requesting new staging review
coolo set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
coolo accepted review
Picked openSUSE:Factory:Staging:I
dimstar_suse accepted review
Removing from openSUSE:Factory:Staging:I, re-evaluation needed
dimstar_suse added factory-staging as a reviewer
Requesting new staging review
repo-checker accepted review
ok
coolo set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
coolo accepted review
Picked openSUSE:Factory:Staging:I
dimstar_suse approved review
ready to accept
dimstar_suse accepted review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
moving pg_config out of postgresql-devel doesn't seem wise - it breaks a lot
breaks libreoffice, apr-util, postfix, redland and rsyslog
pg_config provides information on how the server was configured and to what libraries it was linked, so it should only used by server extensions, but not by client code that links to libpq or libecpg which in turn depend on a much smaller set of libraries than the server.
I'll have a look at the packages that break and see if I can change them to use pkg-config instead of pg_config.
Waiting for apr-util, libreoffice, redland and rsyslog fixes