Overview

Request 685384 superseded

- Fix 'Conflicts'
- Add 'iptables' requires
- Package hyperkube sepraretly
- Add a workaround for https://github.com/rancher/k3s/issues/231
- Add kubectl and crictl symlinks
- Update description
- Add requires to 'conntrack-tools' and 'runc' as it is needed at
runtime
- Fix k3s-agent.service as '-u' is not a valid option
- Update to version 0.2.0:
* Features and Enhancements:
- Support arbitrary CRI implementations [#107] - Users can now
configure k3s to use cri-o and other CRI implementations that
are not packaged into k3s.
- Support for preloading images [#92] - Users can now have node
agents load docker images from a location on the host at startup,
eliminating the need to pull images from a remote location.
- Upgrade to Kubernetes v1.13.4 [#95] - Update to the latest
release of Kubernetes.
- Support k3s on Rancher [#69] - Users can now import k3s
clusters into Rancher (supported in Rancher v2.2.0-rc3 and later).
- Support agent options in server command [#73] - Users can now
set any of the options available to agents when starting the k3s
server node.
- Support the ability to run k3s as non-root user [#38] - User
can now run the k3s server as a non-root user.
- Support the ability to read node token from a file [#98] - Users
can now have the node-agent read its token from a file rather
than passing it as a string.
* Bug fixes:
- Fixed an issue where preloaded deployment manifests fail to
deploy if no namespace is specified #151
- Fixed an issue where changes to helm chart values or
values.yaml aren't always triggering an upgrade #187
- Fixed an issue where nodes with uppercase hostnames hang
indefinitely #160
- Fixed an issue where containerd log level environment variable
is not respected #188
- Fixed an issue where node-token path doesn't resolve for root
user in agent scripts #189
- Fixed an issue where traefik is not listed in the --no-deploy
flag's help text #186
- Fixed an issue where changing cluster CIDR was not possible #93
- Fixed an issue where k3s systemd service should wait until
the server is ready #57
- Fixed an issue where test volume mount e2e fails for k3s
image #45
- Fixed an issue where component status is not accurate #126
- Fixed an issue where install script fails if wget is not
available #48
- Added the ability to dynamically install the latest release
of k3s #47
- Add _constraints to avoid 'cannot allocate memory' error seen
on aarch64
- Initial package - v0.1.0

Loading...

Jan Engelhardt's avatar

A new description is in 686251. That one surely will do better than the underspecified "Great for Edge/IOT/CI/ARM/PhD" to, as rb puts it, “inform any potential users of why they might wish to use it” (or, in fact, not use it), which is in fact exactly what the description recommendations for openSUSE speak of.


Dominique Leuenberger's avatar

https://build.opensuse.org/request/show/686251 was declined - and your blocking review does not help the project


Jan Engelhardt's avatar

His remarks that the (new) description was supposedly not concise, relevant and neutral have been, within the leeway that the guidelines give for "concise", disproven. Needless to state that the (old) description here was not accurate either, let alone describing the package, which is why there's a review here. The ball is in his court.


Dominique Leuenberger's avatar

Then decline it - those reviews on yourself are an annoyance and no help at all


Jan Engelhardt's avatar

lightweight? (very) debatable. easy to install? seems irrelevant to me, it's rpm-ized like everything else. in a binary? I count at least 3. less than 40 mb? Absolute failure.


Richard Brown's avatar
reviewer source maintainer

The description is how upstream describes itself - and who are we to argue. Please clear your review.


Jan Engelhardt's avatar

Before long, there would be an upstream software project describing itself as "100 percent Richard Brown free", and you wouldn't want to see that echoed verbatim in a openSUSE %description, would you?


Dominique Leuenberger's avatar
found conflict of k3s-0.2.0-2.2.x86_64 with kubernetes-client-1.13.4-2.1.x86_64:
  - /usr/bin/kubectl

Request History
Guillaume GARDET's avatar

Guillaume_G created request

- Fix 'Conflicts'
- Add 'iptables' requires
- Package hyperkube sepraretly
- Add a workaround for https://github.com/rancher/k3s/issues/231
- Add kubectl and crictl symlinks
- Update description
- Add requires to 'conntrack-tools' and 'runc' as it is needed at
runtime
- Fix k3s-agent.service as '-u' is not a valid option
- Update to version 0.2.0:
* Features and Enhancements:
- Support arbitrary CRI implementations [#107] - Users can now
configure k3s to use cri-o and other CRI implementations that
are not packaged into k3s.
- Support for preloading images [#92] - Users can now have node
agents load docker images from a location on the host at startup,
eliminating the need to pull images from a remote location.
- Upgrade to Kubernetes v1.13.4 [#95] - Update to the latest
release of Kubernetes.
- Support k3s on Rancher [#69] - Users can now import k3s
clusters into Rancher (supported in Rancher v2.2.0-rc3 and later).
- Support agent options in server command [#73] - Users can now
set any of the options available to agents when starting the k3s
server node.
- Support the ability to run k3s as non-root user [#38] - User
can now run the k3s server as a non-root user.
- Support the ability to read node token from a file [#98] - Users
can now have the node-agent read its token from a file rather
than passing it as a string.
* Bug fixes:
- Fixed an issue where preloaded deployment manifests fail to
deploy if no namespace is specified #151
- Fixed an issue where changes to helm chart values or
values.yaml aren't always triggering an upgrade #187
- Fixed an issue where nodes with uppercase hostnames hang
indefinitely #160
- Fixed an issue where containerd log level environment variable
is not respected #188
- Fixed an issue where node-token path doesn't resolve for root
user in agent scripts #189
- Fixed an issue where traefik is not listed in the --no-deploy
flag's help text #186
- Fixed an issue where changing cluster CIDR was not possible #93
- Fixed an issue where k3s systemd service should wait until
the server is ready #57
- Fixed an issue where test volume mount e2e fails for k3s
image #45
- Fixed an issue where component status is not accurate #126
- Fixed an issue where install script fails if wget is not
available #48
- Added the ability to dynamically install the latest release
of k3s #47
- Add _constraints to avoid 'cannot allocate memory' error seen
on aarch64
- Initial package - v0.1.0


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Stephan Kulow's avatar

coolo added openSUSE:Factory:Staging:adi:43 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:43"


Stephan Kulow's avatar

coolo accepted review

Picked openSUSE:Factory:Staging:adi:43


Jan Engelhardt's avatar

jengelh added jengelh as a reviewer

new description


Saul Goodman's avatar

licensedigger accepted review

ok


Jan Engelhardt's avatar

jengelh declined review

Declining because reviewer and submitter could not yet agree on package descriptions. Further discussion thereof, or on the guidelines for such, seem in order.


Jan Engelhardt's avatar

jengelh declined request

Declining because reviewer and submitter could not yet agree on package descriptions. Further discussion thereof, or on the guidelines for such, seem in order.


openSUSE Build Service is sponsored by