BuildRequires:  pkgconfig(udev)
 Requires:       %{name}-udev
+Requires:       python-future
 Requires:       python-numpy
-Requires:       python-pyside
 Requires:       python-usb
+Requires:       python3-pyside2
+# for rfcat_bootloader
+Requires:       python-pyserial
 BuildArch:      noarch

That can't be right - It's all based on python2 and ONE python3 dependency?

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

afaics, the 4 rfcat executables start without complaining. I don't have a rfcat device to test more.

---

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

If this patch[1] works, we could just replace the pyside2 dependency with python-qt5 until rfcat is fully ported to python3.

[1] https://github.com/3553x/rfcat/commit/8b2ad00da6b25b188b6800aeea3cc811243a8c15

---

John Vandenberg (jayvdb) - about 5 years ago

will try this.

Using python3 library is definitely not right. The repo has a test suite. I'll see if I can get it working.

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

Thanks, can you try the patch I linked above if you have a compatible device?

---

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

the changes have to be applied manually, pyside is only used in this file to create a gui

Broad overview: this package is not even really trying to be Python 3 compatible on master yet.

The setup.py explicitly says not Python 3 compatible with python_requires = '>=2.7,<3.0.0' , and they have Python 3 classifiers in the setup.py commented out.

You can see what it looks like at https://build.opensuse.org/package/show/home:jayvdb:branches:hardware:sdr/rfcat , when we use python3 instead of python to build/install/test it, even after running modernize on it.

I've tried a few tricks to get it working, but the problems are serious, and they are not very good at packaging for Python. There is a reference in setup.py to libusb , which isnt packaged in openSUSE, and isnt compatible with Python 3. c.f. https://build.opensuse.org/package/show/home:jayvdb:branches:hardware:sdr/python-libusb

It does rely on python package usb, and that is a rather large and complicated beast with no tests at all, anywhere. I doubt it is python 3 compatible - probably the core is, as it has users and I dont see outstanding issues about Python 3, but it is so large and complex - and uses bytes a lot - that only a good testsuite would flush out all the bugs.

It also relies on pyserial, and I've started cleaning it up at https://build.opensuse.org/package/show/home:jayvdb:branches:devel:languages:python/python-pyserial , and it looks like it isnt Python 3 either.

rfcat master does explicitly declare dependency on PySide2 , on Python 2, and it seems to actually need it. And openSUSE doesnt have that packaged.

So either :

someone needs to package PySide2 for Python 2 (not a particularly useful thing to do with EOL coming up), or

rfcat needs to be rolled back to a version which uses pyside(1), or

disable the pyside part of rfcat, which is the Spectrum Analyzer mode, if it is useful if that part is removed.

(or someone needs to do a lot of work with upstream to get their code into shape for py3)

John Vandenberg (jayvdb) - about 5 years ago

or use pyside2 on python3 to generate the code for python2 ... i'm going try that next

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

we don't have python2-pyside2 and we don't plan to have it, hence the suggestion to use the changes mentioned above to use python2-qt5.

---

John Vandenberg (jayvdb) - about 5 years ago

manually applied it, and the 'tests' now pass. manually testing..

---

John Vandenberg (jayvdb) - about 5 years ago

Submitted https://build.opensuse.org/request/show/693914

---

Christophe Giboudeaux (cgiboudeaux) - about 5 years ago

Great, thanks for testing.