Overview
Request 459136 superseded
- Replace totally useless description.
- Rename deepin-music-libnetease-meta-search1 again:
it is a plugin, not a standard library!
- Fix RPM group selection. Do not call fdupes on root.
- Qt5 mkspecs belong into -devel subpackage. (forwarded request 459129 from jengelh)
- Created by hillwood
- In state superseded
- Supersedes 458994
- Superseded by 479736
- Open review for openSUSE:Factory:Staging:adi:47
Request History
hillwood created request
- Replace totally useless description.
- Rename deepin-music-libnetease-meta-search1 again:
it is a plugin, not a standard library!
- Fix RPM group selection. Do not call fdupes on root.
- Qt5 mkspecs belong into -devel subpackage. (forwarded request 459129 from jengelh)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
coolo accepted review
ok
factory-repo-checker reopened review
Execution plan: X11:Deepin/openSUSE_Tumbleweed
can't install deepin-music-player-3.0.1-12.1.x86_64:
nothing provides libdtkbase.so.1()(64bit) needed by deepin-music-player-3.0.1-12.1.x86_64
nothing provides libdtkutil.so.1()(64bit) needed by deepin-music-player-3.0.1-12.1.x86_64
nothing provides libdtkwidget.so.1()(64bit) needed by deepin-music-player-3.0.1-12.1.x86_64
maxlin_factory added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:47"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:adi:47
factory-repo-checker accepted review
Builds for repo X11:Deepin/openSUSE_Tumbleweed
dimstar declined review
As already pointed out by simotek: the icon really has to be in /usr/share/icons/hicolor/apps/ - so that it can properly be overridden by themes (if any)
Also, should there ever be an appdata.xml file, the extraction would fail as well if the icon is not in the correct locations.
Let's fix it now, instead of trying to debug it later on
dimstar declined request
As already pointed out by simotek: the icon really has to be in /usr/share/icons/hicolor/apps/ - so that it can properly be overridden by themes (if any)
Also, should there ever be an appdata.xml file, the extraction would fail as well if the icon is not in the correct locations.
Let's fix it now, instead of trying to debug it later on
The following looks wrong, if the icon is in the correct place and correctly named in /usr/share/icons/hicolor/ "deepin-music" should be found +sed -i 's|Icon=deepin-music|Icon=/usr/share/dman/deepin-music/common/deepin-music.svg|g' \
deepin-music-libnetease-meta-search.x86_64: E: summary-not-capitalized (Badness: 63) C libnetease integration for the Deepin Music Player
I don't know if you can do anything about the following, it might just need to be raised upstream deepin-music-player.x86_64: W: invalid-desktopfile /usr/share/applications/deepin-music.desktop file contains group "Next Shortcut Group", but groups extending the format should start with "X-" deepin-music-player.x86_64: W: invalid-desktopfile /usr/share/applications/deepin-music.desktop file contains group "PlayPause Shortcut Group", but groups extending the format should start with "X-" deepin-music-player.x86_64: W: invalid-desktopfile /usr/share/applications/deepin-music.desktop file contains group "Previous Shortcut Group", but groups extending the format should start with "X-"
The summary capitalization is wrong here, but rpmlint can't know that.
Thanks guys, I fixed it in the superseding SR (looks like hillwood become inactive again)