Overview
Loading...
Request History
leaper created request
Automatic request from openSUSE:Factory by UpdateCrawler
leaper added science as a reviewer
Submission for None by someone who is not maintainer in the devel project (science). Please review
leaper added leap-reviewers as a reviewer
leaper accepted review
ok
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Leap:42.3:Staging:adi:60"
staging-bot accepted review
Picked openSUSE:Leap:42.3:Staging:adi:60
jberry accepted review
ok
sbrabec accepted review
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
lnussel_factory accepted request
Accept to openSUSE:Leap:42.3
openSUSE:Factory/chemical-mime-data@8ca8b3f72018fe773a7303da29c40435 -> openSUSE:Leap:42.3/chemical-mime-data
expected origin is 'openSUSE:Factory' (unchanged)
the submitted sources are in or accepted for Factory
@Dmitry_R, @Mailaender, @MasterPatricko, @TheBlackCat, @WernerFink, @adrianSuSE, @badshah400, @cjunghans, @dstoecker, @ealin, @eeich, @namtrac, @psmt, @sbrabec, @scorot, @werner2101: review reminder
LGTM, but I would have just added "CONVERT='/usr/bin/covert -strip' as an option to make, this avoids the chance of having the patch break in the next version.
Patch is mentioned as PATCH-FIX-UPSTREAM, so I expect that the new version will include it. Patch will remind itself, but CONVERT= would have tendencies to stay in spec forever.