This request is superseded by
request 1087756
(Show diff)
Overview
Request 1087745 superseded
Fix problems from the previous one
- Created by slbtongying
- In state superseded
- Supersedes 1086887
- Superseded by 1087756
Loading...
Login required, please
login
in order to comment
@MargueriteSu, @Thruth, @badshah400, @behrisch, @computersalat, @dbalentine, @fabio_s, @fschuett, @fsgaston, @gallochri, @glunardi, @grayswandir12, @kkirill, @lrupp, @lumnis, @maw, @mnhauke, @mpmiranda, @mseben, @repabuild, @vlj, @worldcitizen: review reminder
target maintainer
Thanks for taking this up. Here are my comments about some minor issues:
- Let us treat this as a new package, which it is. There is no need to copy over the changelog entries from another existing package (goldendict).
- The Obsoletes should refer to the current version of goldendict in Factory, i.e. something like
Obsoletes: goldendict < 1.5.1
. This is so that we can get rid of the Obsoletes/Provides some time after the older goldendict has disappeared from Factory. -
git init
(Line number 83 in specfile) is probably unnecessary, otherwise please leave a comment in the specfile as to why it is needed. Likewise, thegit
BuildRequires should also be unnecessary. - Recommend running
spec-cleaner
over the specfile. If you want to preserve sections in BuildRequires, you may use section comments like the following:
# Section ffmpeg6 BuildRequires: foo1 BuildRequires: foo2 # /Section
Please consider superseding this sr with the above fixes.
author
source maintainer
Thanks for reviewing.
I have sent a request that supersedes this one with all the problems you mentioned fixed.
Login required, please
login
in order to comment