Overview
Looks good, except the compiler flags are wrong:
[ 22s] === Sat Feb 3 00:26:41 UTC 2018 === cc -O3 -fomit-frame-pointer -funroll-loops -pedantic -Wall -Wno-long-long -Wno-overlength-strings -Wno-unused-function -Wshadow -Wdeclaration-after-statement -Wwrite-strings -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wunused-value -Wunused-parameter -Wundef -fstack-protector-strong -fwrapv -fno-strict-overflow
Try adding %optflags, so the default compiler flags are inherited.
Otherwise, looks fine are ready for Factory.
Could you check whether this is ok now, please? https://build.opensuse.org/request/show/573710
What exactly is wrong about the compiler flags? Should I use optflags instead of smp_mflags, or in addition to it? Where can I read up on openSUSE's requirements in regards to CFLAGS?
According to this 1 documentation CFLAGS is set to %optflags automatically, so I'm not sure what exactly to do here ...
@EGDFree, @Fisiu, @Ignotusp, @anicka, @azouhr, @darix, @dirkmueller, @hreinecke, @jbohac, @jmcdough, @joachimwerner, @kukuk, @lrupp, @markoschandras, @mkudlvasr, @mpmiranda, @mrdocs, @mseben, @msmeissn, @mtomaschewski, @mvarlese, @namtrac, @ndas, @nemysis, @olh, @prusnak, @psmt, @rhafer, @rmax, @sbrabec, @seife, @varkoly: review reminder