Request 715493 (accepted)

This request supersedes: request 713436 (Show diff)

Overview

Request 715493 accepted

No description set

Created by jsjhb almost 5 years ago
In state accepted
Package maintainer: jsjhb
Supersedes 713436

Submit radsecproxy

Comments for request 715493 2
Comments for request 713436 1

Stefan Botter (jsjhb) - almost 5 years ago

author target maintainer

tried to iron out the welcome requests.

Staging Bot (staging-bot) - almost 5 years ago

@EGDFree, @Fisiu, @anicka, @azouhr, @darix, @dirkmueller, @hreinecke, @jbohac, @jmcdough, @joachimwerner, @lrupp, @msmeissn, @mtomaschewski, @mvarlese, @ndas, @olh, @rhafer, @rmax, @sbrabec, @scarabeus_iv, @seife, @varkoly: review reminder

Stanislav Brabec (sbrabec) - almost 5 years ago

There are three minor issues:

The comment "# 2012-05-16 only on update inform the admin:" indicates that the warning issued on each update is currently obsolete. All openSUSE versions released before 2012 are years after EOL.

rpmlint warning: W: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/radsecproxy This package installs a file in /etc/logrotate.d/ but doesn't require logrotate to be installed. Because logrotate is not part of the essential packages, your package should explicitely depend on logrotate to make sure that your logrotate job is executed. If it is an optional feature of your package, recommend or suggest logrotate.

BuildRequires: patch I do not see any single reference to patch in your package. Additionally, patch is part of the standard build environment, and probably will always be.

Request History

jsjhb created request almost 5 years ago

sbrabec accepted request almost 5 years ago

Spec looks OK. Adding you as a maintainer.

Just a cosmetic issue: It would be nice to avoid use of tabs and rich indentation in the changes file. It is converted to rpm changelog, and that should be well readable even in 80 characters wide terminals.

Places

Overview